[Multi_K8s-Plugin] Implement plan preview#6685
Open
mohammedfirdouss wants to merge 10 commits intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Implement plan preview#6685mohammedfirdouss wants to merge 10 commits intopipe-cd:masterfrom
mohammedfirdouss wants to merge 10 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Contributor
Author
|
CLI test (pipectl): Confirmed working. Running GitHub Actions test: The Latest test PR: mohammedfirdouss/pipecd-test-app#6 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6685 +/- ##
==========================================
- Coverage 29.48% 28.94% -0.55%
==========================================
Files 593 34 -559
Lines 63440 3092 -60348
==========================================
- Hits 18706 895 -17811
+ Misses 43289 2140 -41149
+ Partials 1445 57 -1388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/plan-preview
branch
4 times, most recently
from
4d6dcee to
54f64d4
Compare
Add plugin_test.go and testdata covering single-target and multi-target scenarios. Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
mohammedfirdouss
force-pushed
the
feat/plan-preview
branch
from
54f64d4 to
e1a70bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements Plan Preview for the
kubernetes_multiclusterplugin,the missing feature listed in the plugin's issue.Plan Preview shows users a diff of what will change (added / changed / deleted manifests) before a deployment actually runs. Before this change, the PipeCD UI showed an empty preview panel for all multicluster applications. This PR ports the feature from the single-cluster
kubernetesplugin and extends it to support per-cluster manifest paths viamultiTargets.Why we need it:
Without Plan Preview, users deploying to multiple clusters had no visibility into what resources would be affected before approving a deployment.
Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?:
multiTargets, one diff panel is shown per deploy target. Secret values are masked in the diff output.Viewing plan preview results:
Use pipe-cd/actions-plan-preview to automatically post plan preview diffs as GitHub PR comments when a pull request is opened or updated.